ci: migrate ACR login to OIDC/UAMI managed identity#1000
Merged
BenjaminMichaelis merged 1 commit intomainfrom Apr 22, 2026
Merged
ci: migrate ACR login to OIDC/UAMI managed identity#1000BenjaminMichaelis merged 1 commit intomainfrom
BenjaminMichaelis merged 1 commit intomainfrom
Conversation
- Replace docker/login-action (admin credentials) with az acr login via OIDC session (azure/login with AZURE_CLIENT_ID) - Add --registry-identity and --user-assigned flags to az containerapp up so identity attachment and registry config happen atomically on create and update, eliminating the chicken-and-egg ordering issue - Replace az config set extension.use_dynamic_install with explicit az extension add --name containerapp --upgrade to ensure the extension version supports --registry-identity on az containerapp up - Remove --registry-username/--registry-password from containerapp up - Update Assign MI step to use WEB_UAMI_RESOURCE_ID and WEB_UAMI_CLIENT_ID
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions deployment workflow to authenticate to Azure Container Registry (ACR) and Azure Container Apps using OIDC + user-assigned managed identity (UAMI), removing reliance on ACR admin credentials and making identity/registry attachment occur as part of the az containerapp up operation.
Changes:
- Replace
docker/login-action(ACR username/password) withaz acr loginafterazure/loginOIDC auth. - Update
az containerapp upto use--registry-identityand--user-assigned, removing--registry-username/--registry-password. - Replace dynamic extension install config with explicit
az extension add --name containerapp --upgrade.
BenjaminMichaelis
added a commit
that referenced
this pull request
Apr 25, 2026
- Replace docker/login-action (admin credentials) with az acr login via OIDC session (azure/login with AZURE_CLIENT_ID) - Add --registry-identity and --user-assigned flags to az containerapp up so identity attachment and registry config happen atomically on create and update, eliminating the chicken-and-egg ordering issue - Replace az config set extension.use_dynamic_install with explicit az extension add --name containerapp --upgrade to ensure the extension version supports --registry-identity on az containerapp up - Remove --registry-username/--registry-password from containerapp up - Update Assign MI step to use WEB_UAMI_RESOURCE_ID and WEB_UAMI_CLIENT_ID ## Description Describe your changes here. Fixes #Issue_Number (if available) ### Ensure that your pull request has followed all the steps below: - [ ] Code compilation - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the README / documentation, if necessary Co-authored-by: Benjamin Michaelis <bmichaelis@intellitect.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes here.
Fixes #Issue_Number (if available)
Ensure that your pull request has followed all the steps below: